-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1.0.6베타 QA 반영 #168
feat: 1.0.6베타 QA 반영 #168
Conversation
case let .카테고리상세_이동(category): | ||
if category.categoryName == "미분류" { | ||
state.selectedTab = .pokit | ||
state.path.removeAll() | ||
return .send(.pokit(.delegate(.미분류_카테고리_활성화))) | ||
} | ||
state.path.append(.카테고리상세(.init(category: category))) | ||
return .none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유저마다 미분류 id값이 다르다면 저희가 할 수 있는 최선은 Constants로 빼내는것이긴 한데 ...
단순 문자열로 비교는 좀 별로긴하네요 서버쪽에서 해결해줘야 할 것 같아요..😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 어떻게 하면 좋을까여
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 스테이..
listSheet | ||
.presentationDragIndicator(.visible) | ||
.pokitPresentationCornerRadius() | ||
.presentationDetents([.height(564)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 se는 사이즈 괜찮았나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇.. 확인 해보겠습니다.. 확인한다 해놓고 까먹고 있었,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guard | ||
let contentId = state.domain.contentId, | ||
let categoryId = state.selectedPokit?.id, | ||
let category = state.domain.categoryListInQuiry.data?.first(where: { | ||
$0.id == categoryId | ||
}) | ||
else { return .none } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 컨벤션 좋긴한데 적용하실거면 통일성을 위해서 모든 guard let에 적용하는게 맞다고 생각함
아니라면 이전 컨벤션 적용하고 나중에 전체수정하는걸루
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 괜찮으시다면 다 적용해도 될까요..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
물론~~
고생많으셨습니다~~! 2버전을 향해서 으쌰 |
#️⃣연관된 이슈
#167
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
categoryName
을 비교하여 분기하고 있습니다.(단순 이름 비교라 좀 맘에 안들기도 함...)사용자 별로 미분류 포킷 id가 다르기 때문에 이렇게 하였고, 저번 pr 처럼
"미분류"
라는 문자열을Constant
로 넣으면 좋을지..? 궁금합니다close #167